fix(bot): stop a gatherer walking past the site it is standing on #125

Merged

sickday merged 1 commit from fix/site-choice into main 2026-08-06 00:02:13 +00:00

Conversation 0 Commits 1 Files changed 4 +129 -10

sickday commented 2026-08-05 23:59:04 +00:00

Owner

Copy link

Closes #124.

Bot.Goals.Fish and Bot.Goals.GatherAndBank both chose where to work by
sorting sites by distance, taking the nearest three and rolling between them.
The roll is right — a fleet that all took the nearest would pile onto one site
— but it weighed a site underfoot the same as one across the world, and gather
sites are sparse enough that the runners-up are routinely hundreds of tiles
off. A fisher spawned on a perfectly good ground walked away from it two times
in three.

Bot.Sites.choose/2 is now the one home for that rule, and it drops from the
roll any candidate more than 32 tiles further away than the nearest.
Comparable sites still share it. What that removes is the journey chosen for
no reason, which matters beyond the walking: it is exactly the long leg that
straight-line travel is worst at, so the two together turned working bots into
wedged ones.

The site type is deliberately open, because a closed map of one key is not
what any site in that module is.

Closes #124. `Bot.Goals.Fish` and `Bot.Goals.GatherAndBank` both chose where to work by sorting sites by distance, taking the nearest three and rolling between them. The roll is right — a fleet that all took the nearest would pile onto one site — but it weighed a site underfoot the same as one across the world, and gather sites are sparse enough that the runners-up are routinely hundreds of tiles off. A fisher spawned on a perfectly good ground walked away from it two times in three. `Bot.Sites.choose/2` is now the one home for that rule, and it drops from the roll any candidate more than 32 tiles further away than the nearest. Comparable sites still share it. What that removes is the journey chosen for no reason, which matters beyond the walking: it is exactly the long leg that straight-line travel is worst at, so the two together turned working bots into wedged ones. The site type is deliberately open, because a closed map of one key is not what any site in that module is.

sickday added 1 commit 2026-08-05 23:59:04 +00:00

fix(bot): stop a gatherer walking past the site it is standing on ... 420eddd2ea

Closes #124.

`Bot.Goals.Fish` and `Bot.Goals.GatherAndBank` both chose where to work by
sorting sites by distance, taking the nearest three and rolling between them.
The roll is right — a fleet that all took the nearest would pile onto one site
— but it weighed a site underfoot the same as one across the world, and gather
sites are sparse enough that the runners-up are routinely hundreds of tiles
off. A fisher spawned on a perfectly good ground walked away from it two times
in three.

`Bot.Sites.choose/2` is now the one home for that rule, and it drops from the
roll any candidate more than 32 tiles further away than the nearest.
Comparable sites still share it. What that removes is the journey chosen for
no reason, which matters beyond the walking: it is exactly the long leg that
straight-line travel is worst at, so the two together turned working bots into
wedged ones.

The site type is deliberately open, because a closed map of one key is not
what any site in that module is.

sickday merged commit 420eddd2ea into main 2026-08-06 00:02:13 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Revenant/Server!125

No description provided.