BlackLobster/Server
BlackLobster/Server
Watch
1
0
Fork
You've already forked Server
 0
Code Issues 22 Pull requests Releases Packages 1 Wiki Activity Actions

feat/sfx-sweep #217

Merged
sickday merged 3 commits from feat/sfx-sweep into main 2026-07-23 15:27:29 +00:00
Conversation 0 Commits 3 Files changed 22 +1705 -15
sickday commented 2026-07-23 15:16:35 +00:00
Owner
Copy link
No description provided. 
BoltEffects carried a per-bolt sound id (2911-2920, all verified present
in the 468 synth archive) but send_bolt_proc_gfx only ever sent the gfx,
so procs like dragon bolt (e) dragonfire were silent. The proc now also
plays its sound to the shooter, delayed to projectile arrival in client
cycles, matching the magic impact sfx path.
The 468 synth archive is dense 0..3826 and its id space is shared with
the reference servers, so reference sound data ports directly with an
id <= 3826 era gate (the bound doubles as the presence check).

New reference-extracted tables (scripts/extract_item_sounds.exs, same
identity gates as the attack-anims extraction):
- item_attack_sounds.exs (382 weapons, per-fight-mode swing sounds) via
  Game.Item.AttackSounds; unarmed falls back to the bare-fist punch,
  Barrows ladders resolve in both directions.
- item_equip_sounds.exs (757 items) via Game.Item.EquipSounds with the
  generic equip thud as default.

Wired server-side sends (client op-13 already covers woodcutting,
mining, smithing-anvil, firemaking, and fletching swings):
- combat: weapon swing sounds on all eight player melee/ranged swing
  paths, NPC attack sound on both NPC swing paths, NPC defend sound on
  damage receipt, gendered player hurt grunts and death cries.
- prayers: per-prayer activation sounds (Chivalry 3826 / Piety 3825 -
  crossed, both references agree), shared deactivation, altar recharge.
- items: eat/drink on consume, bury bones, drop, equip.
- magic: spell-teleport windup audible nearby, home-teleport per-stage
  sounds on the emote chain.
- skilling: smelting, spinning, gem cutting, glassblowing, molten
  glass, pottery firing, jewellery, potion mixing, pickpocket and
  stall theft, rock-depletion crumble.
- world: door/gate open and close, classified from the loc name.

All ids cache-presence-verified; sound delays ride the same client-
cycle convention as the magic impact sfx.
fix: door-close sound is 60, not the 61 creak
All checks were successful
ci / test (pull_request) Successful in 2m35s
Details
a9c85d0452
 
Auditioned in-game: 61 is a creak effect; 60 is the actual close.
sickday force-pushed feat/sfx-sweep from a9c85d0452
All checks were successful
ci / test (pull_request) Successful in 2m35s
Details
to bea0ed9e14
All checks were successful
ci / test (pull_request) Successful in 2m35s
Details
2026-07-23 15:20:21 +00:00 Compare
sickday referenced this pull request from a commit 2026-07-23 15:27:30 +00:00
feat/sfx-sweep (#217)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Defect or regression in existing behavior

  
ci-cd
Build, test, release automation (Forgejo Actions)

  
client
Kotlin/468 client codebase

  
epic:security-hardening
Security & data-integrity hardening epic

  
feature
Missing or planned functionality

  
optimization
Performance / efficiency / hot-path work

  
priority:high
Release-blocking: core systems & correctness

  
priority:low
Polish, niche content, deferred/minor

  
priority:medium
Important, expected for v1, not blocking

  
server
Elixir/OTP server codebase

No labels
bug
ci-cd
client
epic:security-hardening
feature
optimization
priority:high
priority:low
priority:medium
server
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
BlackLobster/Server!217
No description provided.