Kill credit is the last hit, not damage dealt #60

New issue

Closed

opened 2026-07-30 21:02:23 +00:00 by sickday · 0 comments

sickday commented

2026-07-30 21:02:23 +00:00

Owner

World.Npc.damage/3 takes a killer and remembers the last one, and the pile
a death drops is owned by whoever that was. The live game awards a kill on
damage dealt.

Nothing here tracks a fight, so the last hit is as much as anything can know
today. The argument already exists on damage/3 so combat has somewhere to put
a better answer and no reason to invent a second path, but the tracking itself
does not exist:

no per-NPC damage tally by attacker;
no decision about what happens when the top damager has logged out, or is out
of range, or was in a different party;
no concept of a party or of shared credit at all.

Everything downstream is already in place: the pile is an ordinary drop with an
owner, so it is private to the credited player for a minute and public for two
more without any new machinery.

Blocking for a stable release only if a release includes combat. Filed now
because the seam it lands in is built and it is easy to leave the last-hit rule
in place by accident.

`World.Npc.damage/3` takes a killer and remembers the **last** one, and the pile a death drops is owned by whoever that was. The live game awards a kill on **damage dealt**. Nothing here tracks a fight, so the last hit is as much as anything can know today. The argument already exists on `damage/3` so combat has somewhere to put a better answer and no reason to invent a second path, but the tracking itself does not exist: * no per-NPC damage tally by attacker; * no decision about what happens when the top damager has logged out, or is out of range, or was in a different party; * no concept of a party or of shared credit at all. Everything downstream is already in place: the pile is an ordinary drop with an owner, so it is private to the credited player for a minute and public for two more without any new machinery. Blocking for a stable release only if a release includes combat. Filed now because the seam it lands in is built and it is easy to leave the last-hit rule in place by accident.

sickday referenced this issue from a commit

2026-07-31 18:25:19 +00:00

feat: melee combat

sickday closed this issue

2026-07-31 18:25:19 +00:00

sickday referenced this issue from a pull request that will close it,

2026-07-31 18:25:30 +00:00

feat: melee combat #83