Sweep `value || default` truthy-empty-struct traps over DB-loaded values #48

New issue

Closed

opened 2026-06-11 14:06:27 +00:00 by sickday · 0 comments

sickday commented

2026-06-11 14:06:27 +00:00

Owner

Problem

db_value || default uses default only when db_value is nil/false — but a present-but-empty %{}/struct is truthy, so the wrong (empty) value is used. Already bit us once (do_spawn empty appearance → broken encode → bot silently dropped; see the botgen_skeleton_appearance_fast_restart note).

Task

Grep for || / Map.get(.., key) || patterns over DB-loaded values and replace with explicit emptiness checks where an empty map/list/struct is a valid-but-wrong value.

Acceptance

No DB-hydration path treats a present-but-empty structure as "missing".

Part of the Security & Data-Integrity Hardening epic.

## Problem `db_value || default` uses `default` only when `db_value` is `nil`/`false` — but a present-but-empty `%{}`/struct is **truthy**, so the wrong (empty) value is used. Already bit us once (`do_spawn` empty appearance → broken encode → bot silently dropped; see the `botgen_skeleton_appearance_fast_restart` note). ## Task Grep for `|| ` / `Map.get(.., key) ||` patterns over DB-loaded values and replace with explicit emptiness checks where an empty map/list/struct is a valid-but-wrong value. ## Acceptance - No DB-hydration path treats a present-but-empty structure as "missing". Part of the Security & Data-Integrity Hardening epic.

sickday referenced this issue

2026-06-11 14:06:43 +00:00

Epic: Security & Data-Integrity Hardening #50

sickday added the

bug

epic:security-hardening

priority:low

server

labels

2026-06-11 14:07:40 +00:00

sickday added this to the v1 milestone

2026-06-11 14:11:16 +00:00