Aggro leash chases into buildings + NPC return-home strands indoors (Black wizard in Draynor bank) #175
Labels
No labels
bug
ci-cd
client
epic:security-hardening
feature
optimization
priority:high
priority:low
priority:medium
server
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
BlackLobster/Server#175
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
An aggressive Black wizard chased me from its spawn area INTO Draynor bank and kept attacking me inside. Its leash should have released the chase and rehomed it well before it crossed into the bank building. After I ran off, it then failed to walk back to its home area and is now permanently stuck inside the bank (it no longer re-aggros, it just stands there).
Two defects:
Leash allows chasing into interiors. The combat leash is a spawn-anchored radius (
walk_range + 8), so any building inside that radius — including Draynor bank, which sits close to the wizard spawns — is fair game for a chase. The leash needs either a tighter bound or an interior/threshold rule so aggressive NPCs break off before following a player through doorways into buildings. Worth checking what the era-correct behavior is (break-off at leash edge and walk home is the current model; the radius just reaches too far here).Return-home walk gets stuck indoors and never recovers.
maybe_return_homewalked the wizard toward its anchor but it wedged on the bank interior (booths/doorway) and stayed there indefinitely. There's no stuck-detection or teleport-home fallback on the NPC return path, so a single bad walk strands the NPC forever — it stops aggroing (target cleared each tick past the leash) but occupies the bank as furniture.Repro: aggro a Black wizard near Draynor, run into the bank, let it follow, then leave. It attacks inside the bank, then strands there when it tries to go home.
Fix sketch: (a) break chase at the leash edge before entering interiors (or shrink the leash radius for spawns adjacent to buildings), (b) give the NPC return-home path the same stuck-detection + snap-home fallback bots have — an NPC that can't path home within N ticks should teleport to its spawn anchor.
Possibly shares a root cause with the bot Nav reroute storm (walker blindness to door-class obstacles): the wizard's home path likely fails on the bank door the same way bots fail on the Al Kharid toll gate.
To expand on this, Dark Wizards seem to be able to stack on a player even though Draynor Village is not a multi-combat zone.